From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Tue, 7 May 2013 18:25:06 +0000 (+0100)
Subject: Don't put non-Shell windows in Ctrl+Alt+Tab if they wouldn't be visible
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~4214
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=1eeeead78f6523071606fdcfa7c4c1c48264381f;p=gnome-shell.git

Don't put non-Shell windows in Ctrl+Alt+Tab if they wouldn't be visible

Metacity's Ctrl+Alt+Tab would include X11 windows
with hints like GDK_WINDOW_TYPE_HINT_DOCK and
GDK_WINDOW_TYPE_HINT_DESKTOP (there are more conditions, but that's a
good start). If we're in normal mode, those are visible and it's OK
to display those in the Ctrl+Alt+Tab order, but if we're in the lock
screen or the unlock dialog, they're not visible and it doesn't make
sense to focus them.

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=699862
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Florian Müllner <fmuellner@gnome.org>
---

diff --git a/js/ui/ctrlAltTab.js b/js/ui/ctrlAltTab.js
index 6fbd24ebd..dbb1fe038 100644
--- a/js/ui/ctrlAltTab.js
+++ b/js/ui/ctrlAltTab.js
@@ -89,7 +89,7 @@ const CtrlAltTabManager = new Lang.Class({
         let items = this._items.filter(function (item) { return item.proxy.mapped; });
 
         // And add the windows metacity would show in its Ctrl-Alt-Tab list
-        if (!Main.overview.visible) {
+        if (Main.sessionMode.hasWindows && !Main.overview.visible) {
             let screen = global.screen;
             let display = screen.get_display();
             let windows = display.get_tab_list(Meta.TabList.DOCKS, screen, screen.get_active_workspace ());